fix(node-plop): Correct types #367
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the code from these lines: - https://github.com/plopjs/plop/blob/main/packages/node-plop/src/actions/append.js#L32 - https://github.com/plopjs/plop/blob/973c1ce566db6fc754af55672b47ae4ed80ae4d0/packages/node-plop/src/actions/modify.js#L30 both actions `modify` and `optional` accepts `pattern` as optional.
According to this code: https://github.com/plopjs/plop/blob/973c1ce566db6fc754af55672b47ae4ed80ae4d0/packages/node-plop/src/actions/addMany.js#L15 there's no property defined `path`, nor used. The property was incorrectly inherited from `AddManyConfig`.
xeho91
changed the title
pattern to optional in AppendActionConfig & ModifyActionConfig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I love using your package to improve my workflows. Thanks for it!
While coding something new, I found a few typing issues, so I thought of immediately fixing them.
According to the code from these lines:
plop/packages/node-plop/src/actions/append.js
Line 32 in 973c1ce
plop/packages/node-plop/src/actions/modify.js
Line 30 in 973c1ce
both action types -
"append"and"modify"- acceptpatternproperty in options (cfg) optionally.Another one is the incorrectly inherited property
pathinsideAddManyActionConfigfromAddActionCOnfig. I've confirmed there, that it is actually not being used at all.Source:
plop/packages/node-plop/src/actions/addMany.js
Line 15 in 973c1ce